Skip to content

Add support for Django 4#24

Merged
sonus21 merged 2 commits into
sonus21:masterfrom
jeduardo211:django_4
May 26, 2022
Merged

Add support for Django 4#24
sonus21 merged 2 commits into
sonus21:masterfrom
jeduardo211:django_4

Conversation

@jeduardo211

@jeduardo211 jeduardo211 commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

Django 4.0 no longer contains the url method for defining routes.
This pull request defines the routers using the more modern path method, and defines the app_name to allow for URLs namespaces.

@jeduardo211
Use path instead of url to support Django 4
a483a9c 
The old way of defining urls in DJango is no longer supported in Django 4.0.

This commit replaces the regular expression based paths by the more modern path method, and also adds app_name in the urls file to allow usage with URL namespaces.
@jeduardo211
Increase version
831e6f3 
Altered major version because old versions of Django cannot be supported anymore.
@denpufa

denpufa commented May 9, 2022

Copy link
Copy Markdown

can aprove this pr?

@sonus21

sonus21 commented May 10, 2022

Copy link
Copy Markdown
Owner

@denpufa can you please share test report?
./run-tests.sh

@sonus21

sonus21 commented May 10, 2022

Copy link
Copy Markdown
Owner

@jeduardo211 ^

@denpufa

denpufa commented May 25, 2022

Copy link
Copy Markdown 
/home/rodolfo/error-tracker/error_tracker/django/__init__.py:28: UserWarning: APP_ERROR_DB_MODEL is not set using default model
  warnings.warn("APP_ERROR_DB_MODEL is not set using default model")
/home/rodolfo/error-tracker/error_tracker/libs/utils.py:121: UserWarning: Default Masking module will be used
  warnings.warn(message)
/home/rodolfo/error-tracker/error_tracker/libs/utils.py:121: UserWarning: Default ContextBuilder module will be used
  warnings.warn(message)
Creating test database for alias 'default'...
/home/rodolfo/error-tracker/error_tracker/django/__init__.py:28: UserWarning: APP_ERROR_DB_MODEL is not set using default model
  warnings.warn("APP_ERROR_DB_MODEL is not set using default model")
/home/rodolfo/error-tracker/error_tracker/django/__init__.py:28: UserWarning: APP_ERROR_DB_MODEL is not set using default model
  warnings.warn("APP_ERROR_DB_MODEL is not set using default model")
.................
----------------------------------------------------------------------
Ran 17 tests in 1.685s

OK

@sonus21 django report here, want flask too?

@sonus21 sonus21 merged commit d819f97 into sonus21:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeduardo211 @denpufa @sonus21